Editorial: Consistently mark increment as "positive integer" #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to validate the math in NudgeToCalendarUnit when calling ApplyUnsignedRoundingMode. It also matches other operations which already require that `increment` is a positive integer.
anba
force-pushed
the
increment-positive-integer
branch
from
67b7f42
to
235ae8f
Compare
anba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to validate the math in NudgeToCalendarUnit when calling ApplyUnsignedRoundingMode. It also matches other operations which already require that
incrementis a positive integer.(Cherry-picked from #2884.)