-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correlating original sources with sourcemapped scripts #21
Comments
A simple solution to the problem of mapping known local sources to unknown remote sources would be the addition of a Considerations:
|
On the note of That said I much prefer having explicit debug IDs as it can be supported without browser API support (an XHR request to the file to read the comment) and it addresses the issue of what happens if only one side changes. |
Yea, if
I think our use cases are different here. In js-debug, whose users are primarily iterating from a local or remote development server, mapping from artifact to sourcemap is never much of an issue. But I don't see debug IDs / sourcesHash as an "either/or" situation. |
For what it's worth I definitely see a use for |
Fix checking IPR in pull requests
As discussed in the recent discussion (#22), a challenge and consistent point of difficult configuration for the VS/Code JS debugger is figuring out how compiled sources map to on-disk sources. It's easy when dealing with a simple sourcemaps containing absolute or relative filepaths on disk (i.e. in Node.js), but it can get increasingly complicated when introducing compilers, bundlers, and servers that might map a source to another arbitrary path.
Ideally such a mapping is independent of any source filesystems, such that two different users debugging the same code on a public webserver can have their sources map correctly; this rules out simply requiring absolute file URIs, not mentioning the leak of local filepaths that might happen.
The text was updated successfully, but these errors were encountered: