Scopes: Update binding expression parsing
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the order of binding expressions to use encode `M` first. If `M` is >= -1, then `M` is treated as an offset into `names` for the entirety of the generated range. If it's negative, then there are `-M` sub-ranges for this variable within the generated range, and the next VLQ is the offset into `names` to use for the start of the generated range.
hbenl
approved these changes
Jun 25, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2024
SHA: 85ed738 Reason: push, by jkup Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Jun 27, 2024
The PR tc39/source-map#106 changes the 'bindings' encoding of the "Scopes" proposal to encode the number of sub-ranges first. This way, we don't have to look ahead in the VLQ stream to decode bindings. This CL aligns the DevTools implementation with the PR. R=pfaffe@chromium.org Bug: 40277685 Change-Id: Ice70c87b4176cfbe23a401b2b336fab144ca99ff Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5660062 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
github-actions bot
added a commit
to szuend/source-map
that referenced
this pull request
Jul 8, 2024
SHA: 85ed738 Reason: push, by szuend Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the order of binding expressions to use encode
Mfirst. IfMis >= -1, thenMis treated as an offset intonamesfor the entirety of the generated range. If it's negative, then there are-Msub-ranges for this variable within the generated range, and the next VLQ is the offset intonamesto use for the start of the generated range.