Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to TC39 spec #71

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Link to TC39 spec #71

merged 1 commit into from
Mar 4, 2024

Conversation

jridgewell
Copy link
Member

No description provided.

@nicolo-ribaudo nicolo-ribaudo merged commit 4723d15 into tc39:main Mar 4, 2024
@nicolo-ribaudo
Copy link
Member

Thanks!

@littledan
Copy link
Member

Huh? I thought we were going to keep linking to the previous spec until we met certain exit criteria #35 . We can link to the under-development spec, but we shouldn't identify it as v3 at this point.

@jridgewell
Copy link
Member Author

Before we publish our own specification, sure it'd make sense to hit those exit criteria. But I think it's completely reasonable for our RFC repo to directly link to our spec repo.

@jridgewell jridgewell deleted the patch-1 branch March 5, 2024 02:23
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Mar 5, 2024

Isn't this like linking to tc39.es/ecma262 rather than to a published version? i.e. the draft source maps spec is already an improvement over the Google doc, but it's still not published and marked as draft (until we meet the exit criteria).

For people looking at this repo and thus interested in source map proposals, the last version of the draft is much more useful than an older one.

@littledan
Copy link
Member

Yeah, I wanted us to get to those exit criteria before publishing something equivalent to tc39.es/ecma262 (which is viewed as an authoritative reference, as it should be, even though it doesn't have official status) and then we can continue updating this draft as a "living standard".

What I would prefer is if we did link to this draft, but identified it as "not 100% ready yet", and also linked to the previous v3 spec, and identified it as "historical"--this patch just identifies the current draft as v3, which seems confusing.

Anyway, maybe we should consider ourselves to have met whatever minimum exit-to-promoted-draft milestone; I would have just preferred explicit discussion/acknowledgement of this.

@nicolo-ribaudo
Copy link
Member

What I would prefer is if we did link to this draft, but identified it as "not 100% ready yet", and also linked to the previous v3 spec, and identified it as "historical"

In the first few lines of the draft document it says that it's a strawman and it links to the historical version -- do you suggest to also keep both links in the readme?

Anyway, maybe we should consider ourselves to have met whatever minimum exit-to-promoted-draft milestone; I would have just preferred explicit discussion/acknowledgement of this.

Yes I agree we should discuss together whether we meet some minimum requirement yet, but I disagree that linking to the draft we're working on in this repo is marking it as "ready" in any way.

Anyway, let's revert this and discuss it at the next meeting?

nicolo-ribaudo added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants