Update tests for TypedArrays/DataView non-interoperable get accessor …

…methods Fixes gh-582
tc39 · Apr 25, 2016 · 8666265 · 8666265
1 parent cf68c3b
commit 8666265
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 81 deletions.
diff --git a/test/built-ins/TypedArray/prototype/buffer/return-dataview-buffer.js b/test/built-ins/TypedArray/prototype/buffer/return-dataview-buffer.js
diff --git a/...this-has-no-viewedarraybuffer-internal.js → ...er/this-has-no-typedarrayname-internal.js b/...this-has-no-viewedarraybuffer-internal.js → ...er/this-has-no-typedarrayname-internal.js
@@ -1,19 +1,21 @@
 // Copyright (C) 2016 the V8 project authors. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
+esid: sec-get-%typedarray%.prototype.buffer
 es6id: 22.2.3.1
 description: |
-  Throws a TypeError exception when `this` does not have a [[ViewedArrayBuffer]]
+  Throws a TypeError exception when `this` does not have a [[TypedArrayName]]
   internal slot
 info: >
   22.2.3.1 get %TypedArray%.prototype.buffer
 
   1. Let O be the this value.
   2. If Type(O) is not Object, throw a TypeError exception.
-  3. If O does not have a [[ViewedArrayBuffer]] internal slot, throw a TypeError
+  3. If O does not have a [[TypedArrayName]] internal slot, throw a TypeError
   exception.
   ...
 includes: [testTypedArray.js]
+features: [DataView]
 ---*/
 
 var TypedArrayPrototype = TypedArray.prototype;
@@ -33,3 +35,8 @@ var ab = new ArrayBuffer(8);
 assert.throws(TypeError, function() {
   getter.call(ab);
 });
+
+var dv = new DataView(new ArrayBuffer(8), 0);
+assert.throws(TypeError, function() {
+  getter.call(dv);
+});
diff --git a/test/built-ins/TypedArray/prototype/byteLength/return-dataview-bytelength.js b/test/built-ins/TypedArray/prototype/byteLength/return-dataview-bytelength.js
diff --git a/...this-has-no-viewedarraybuffer-internal.js → ...th/this-has-no-typedarrayname-internal.js b/...this-has-no-viewedarraybuffer-internal.js → ...th/this-has-no-typedarrayname-internal.js
@@ -1,19 +1,21 @@
 // Copyright (C) 2016 the V8 project authors. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
+esid: sec-get-%typedarray%.prototype.bytelength
 es6id: 22.2.3.2
 description: |
-  Throws a TypeError exception when `this` does not have a [[ViewedArrayBuffer]]
+  Throws a TypeError exception when `this` does not have a [[TypedArrayName]]
   internal slot
 info: >
   22.2.3.2 get %TypedArray%.prototype.byteLength
 
   1. Let O be the this value.
   2. If Type(O) is not Object, throw a TypeError exception.
-  3. If O does not have a [[ViewedArrayBuffer]] internal slot, throw a TypeError
+  3. If O does not have a [[TypedArrayName]] internal slot, throw a TypeError
   exception.
   ...
 includes: [testTypedArray.js]
+features: [DataView]
 ---*/
 
 var TypedArrayPrototype = TypedArray.prototype;
@@ -33,3 +35,8 @@ var ab = new ArrayBuffer(8);
 assert.throws(TypeError, function() {
   getter.call(ab);
 });
+
+var dv = new DataView(new ArrayBuffer(8), 0);
+assert.throws(TypeError, function() {
+  getter.call(dv);
+});
diff --git a/test/built-ins/TypedArray/prototype/byteOffset/return-dataview-byteoffset.js b/test/built-ins/TypedArray/prototype/byteOffset/return-dataview-byteoffset.js
diff --git a/...this-has-no-viewedarraybuffer-internal.js → ...et/this-has-no-typedarrayname-internal.js b/...this-has-no-viewedarraybuffer-internal.js → ...et/this-has-no-typedarrayname-internal.js
@@ -1,19 +1,21 @@
 // Copyright (C) 2016 the V8 project authors. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
+esid: sec-get-%typedarray%.prototype.byteoffset
 es6id: 22.2.3.3
 description: |
-  Throws a TypeError exception when `this` does not have a [[ViewedArrayBuffer]]
+  Throws a TypeError exception when `this` does not have a [[TypedArrayName]]
   internal slot
 info: >
   22.2.3.3 get %TypedArray%.prototype.byteOffset
 
   1. Let O be the this value.
   2. If Type(O) is not Object, throw a TypeError exception.
-  3. If O does not have a [[ViewedArrayBuffer]] internal slot, throw a TypeError
+  3. If O does not have a [[TypedArrayName]] internal slot, throw a TypeError
   exception.
   ...
 includes: [testTypedArray.js]
+features: [DataView]
 ---*/
 
 var TypedArrayPrototype = TypedArray.prototype;
@@ -33,3 +35,8 @@ var ab = new ArrayBuffer(8);
 assert.throws(TypeError, function() {
   getter.call(ab);
 });
+
+var dv = new DataView(new ArrayBuffer(8), 0);
+assert.throws(TypeError, function() {
+  getter.call(dv);
+});