Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for interoperable TypedArray/DataView accessors #582

Closed
littledan opened this issue Apr 16, 2016 · 1 comment
Closed

Fix tests for interoperable TypedArray/DataView accessors #582

littledan opened this issue Apr 16, 2016 · 1 comment

Comments

@littledan
Copy link
Member

littledan commented Apr 16, 2016

Interoperability between TypedArray and DataView accessors was removed in tc39/ecma262@1d7f90e . However, newly added test262 tests check for the old 2015 semantics, such as https://github.com/tc39/test262/blob/master/test/built-ins/TypedArray/prototype/buffer/return-dataview-buffer.js , test for them to actually be interoperable. Instead, these tests should check that a TypeError is thrown, as in the ES2017 draft specification.

@leobalter
Copy link
Member

Sure! I was waiting for tc39/ecma262#410 to get merged so I could work on every changes, but I'll do it as it won't take so long to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants