Tests for export * as ns from 'foo' syntax
#1498
Conversation
| @@ -22,3 +22,5 @@ export { indirectIdName } from './instn-star-props-nrml-indirect_FIXTURE.js'; | |||
| export { indirectIdName as indirectIdName2 } from './instn-star-props-nrml-indirect_FIXTURE.js'; | |||
|
|
|||
| export * from './instn-star-props-nrml-star_FIXTURE.js'; | |||
|
|
|||
| export * as exportns from './instn-star-props-nrml-star-as-exportns_FIXTURE.js'; | |||
There was a problem hiding this comment.
I assume you will still split this part into a new file?
same for test/language/module-code/instn-star-props-nrml.js
In this case, tests LGTM.
There was a problem hiding this comment.
I'm actually really not sure what you are asking, @leobalter
spectranaut
force-pushed
the
export-ns-from
branch
from
5ed0b9e
to
b0ad5c6
Compare
|
@spectranaut is this still "WIP", or ready to land? |
|
Hey @rwaldron -- don't land, we are still waiting for the spec change PR. |
|
@spectranaut got it, thanks! |
spectranaut
force-pushed
the
export-ns-from
branch
from
b0ad5c6
to
1d398bc
Compare
|
Can the title be updated to indicate it’s no longer WIP, since the label now indicates it’s not yet ready to land? |
leobalter
changed the title
export * as ns from 'foo' syntaxexport * as ns from 'foo' syntax
spectranaut
force-pushed
the
export-ns-from
branch
2 times, most recently
from
ec88bf0
to
4c6bb69
Compare
spectranaut
force-pushed
the
export-ns-from
branch
from
4c6bb69
to
cebd8d8
Compare
spectranaut
force-pushed
the
export-ns-from
branch
from
cebd8d8
to
cbb5c2c
Compare
|
@rwaldron @leobalter -- I've added the feature tag, so I believe it is ok to merge? |
|
This seems like it needs a rebase first. |
spectranaut
force-pushed
the
export-ns-from
branch
from
cbb5c2c
to
71373f9
Compare
|
Rebasing and merging |
leobalter
force-pushed
the
export-ns-from
branch
from
71373f9
to
be97b42
Compare
leobalter
force-pushed
the
export-ns-from
branch
from
be97b42
to
fd9b982
Compare
|
|
||
| var x; | ||
| export default x; | ||
| export * as default from 'early-dup-export-start-as-dflt.js'; |
There was a problem hiding this comment.
I think it would make sense to have a positive test case for export * as default from.
|
For parser testing, I think it makes sense to have another positive test case for |
Tests for this PR:
tc39/ecma262#1005Now this PR: tc39/ecma262#1174
One or two more commits of tests to come.