New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `export * as ns from "mod”` updates. #1005

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jdalton
Member

jdalton commented Sep 18, 2017

This PR adds export * as ns from "mod" updates
from tc39/proposal-export-ns-from to the spec as part of the July 27, 2017 notes.

Tests to tc39/test262 soon to follow. \cc @benjamn

Show outdated Hide outdated spec.html
Show outdated Hide outdated spec.html
@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Mar 1, 2018

Member

@jdalton i believe this needs tests and a rebase, and then it can come back to the committee for consensus?

Member

ljharb commented Mar 1, 2018

@jdalton i believe this needs tests and a rebase, and then it can come back to the committee for consensus?

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Mar 1, 2018

Member

Yes. I think @leobalter is on task for tests.

Member

jdalton commented Mar 1, 2018

Yes. I think @leobalter is on task for tests.

@spectranaut

This comment has been minimized.

Show comment
Hide comment
@spectranaut

spectranaut Mar 15, 2018

Hi @jdalton can you review this PR? tc39/proposal-export-ns-from#9
I think there is a bug in the spec!

By the way I'm writing these test instead of @leobalter, expect next week :)

spectranaut commented Mar 15, 2018

Hi @jdalton can you review this PR? tc39/proposal-export-ns-from#9
I think there is a bug in the spec!

By the way I'm writing these test instead of @leobalter, expect next week :)

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Mar 15, 2018

Member

can you review this PR?

Will do!

By the way I'm writing these test instead of @leobalter, expect next week :)

Thank you!

Member

jdalton commented Mar 15, 2018

can you review this PR?

Will do!

By the way I'm writing these test instead of @leobalter, expect next week :)

Thank you!

@spectranaut

This comment has been minimized.

Show comment
Hide comment
@spectranaut

spectranaut Mar 21, 2018

Hey @jdalton -- when reviewing the spec changes I found them to be incomplete! More work needs to be done here, I tried to outline the problem clearly in this issue: tc39/proposal-export-ns-from#10

Probably this PR should be closed, and a new one opened after finishing the proposal?

spectranaut commented Mar 21, 2018

Hey @jdalton -- when reviewing the spec changes I found them to be incomplete! More work needs to be done here, I tried to outline the problem clearly in this issue: tc39/proposal-export-ns-from#10

Probably this PR should be closed, and a new one opened after finishing the proposal?

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Mar 21, 2018

Member

Please leave this one open, and update it as needed.

Member

ljharb commented Mar 21, 2018

Please leave this one open, and update it as needed.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Mar 22, 2018

Member

We lost the reference of the source branch/fork of this PR, so we can’t update this same PR. I told Val the best workaround would be importing this PR content and add other commits in another PR. I can make some to keep the original author info if it helps.

Member

leobalter commented Mar 22, 2018

We lost the reference of the source branch/fork of this PR, so we can’t update this same PR. I told Val the best workaround would be importing this PR content and add other commits in another PR. I can make some to keep the original author info if it helps.

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Mar 22, 2018

Member

@leobalter No worries, do what's easiest. I don't care about the author cred for the PR.

Member

jdalton commented Mar 22, 2018

@leobalter No worries, do what's easiest. I don't care about the author cred for the PR.

@spectranaut

This comment has been minimized.

Show comment
Hide comment
@spectranaut

spectranaut Mar 28, 2018

I'll draft some spec changes to the appropriate methods (outlined here: tc39/proposal-export-ns-from#10) and open a new PR next week!

spectranaut commented Mar 28, 2018

I'll draft some spec changes to the appropriate methods (outlined here: tc39/proposal-export-ns-from#10) and open a new PR next week!

@spectranaut

This comment has been minimized.

Show comment
Hide comment
@spectranaut

spectranaut Apr 17, 2018

Before I open the new PR, would anyone like to review the changes in the pretty diff form: https://spectranaut.github.io/proposal-export-ns-from/

spectranaut commented Apr 17, 2018

Before I open the new PR, would anyone like to review the changes in the pretty diff form: https://spectranaut.github.io/proposal-export-ns-from/

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Apr 17, 2018

Member

@spectranaut looks great to me (altho it should get many more eyes, and I'm not great on grammar/syntax stuff), i have a few small comments/questions but they can wait for the PR.

Member

ljharb commented Apr 17, 2018

@spectranaut looks great to me (altho it should get many more eyes, and I'm not great on grammar/syntax stuff), i have a few small comments/questions but they can wait for the PR.

@spectranaut

This comment has been minimized.

Show comment
Hide comment
@spectranaut

spectranaut commented Apr 17, 2018

@ljharb, @leobalter, @jdalton : I made a new PR: #1174

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Apr 17, 2018

Member

Moved to #1174.

Member

jdalton commented Apr 17, 2018

Moved to #1174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment