Fix and update tests #1788
Merged
Fix and update tests #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the expected NaN result is a (locale-dependent) string
This will allow implementations to test the rest of the number formatting tests, even if the extra precision support isn't implemented.
leobalter
approved these changes
Sep 24, 2018
|
LGTM, @ljharb do you want to confirm the tests verify the intended changes in the proposal for matchAll?? |
|
@leobalter yes, please, that'd be great. i'm hoping to have that done by this evening; after i've stamped then feel free to merge <3 |
ljharb
approved these changes
Sep 25, 2018
| @@ -31,7 +30,8 @@ var o = { | |||
| get [Symbol.match]() { | |||
| ++count; | |||
| return false; | |||
| } | |||
| }, | |||
| flags: "", | |||
There was a problem hiding this comment.
should this be get flags() { } and increment a flagsCount, to ensure this is looked up?
There was a problem hiding this comment.
this can be added as a follow up if you don't mind.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d0cec12
9c704c1
String(...)to convert symbol value to a string, because the implicit ToString conversion throws a TypeError."NaN".75e4fed
d51d6d3