Test ISO strings with extended year -000000 #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
reviewed
Apr 11, 2022
|
|
||
| for (const str of invalidStrings) { | ||
| assert(Number.isNaN(Date.parse(str)), "reject minus zero as extended year"); | ||
| } |
There was a problem hiding this comment.
I'm not going to block on this, but why not just write it like this?
assert.sameValue(Date.parse("-000000-03-31T00:45Z"), NaN);
assert.sameValue(Date.parse("-000000-03-31T01:45"), NaN);
assert.sameValue(Date.parse("-000000-03-31T01:45:00+01:00"), NaN);There was a problem hiding this comment.
Ah, you're right that sameValue does work on NaN. Just habits from elsewhere 😄
There was a problem hiding this comment.
I do prefer the loop since IMO it makes clear to the reader what changes between each assertion and what doesn't.
In Date.parse() and new Date(), representations of the year 0 as -000000 must not be accepted. In the case of Date.parse(), they should yield NaN, and in the case of new Date(), they should yield an invalid Date object, whose valueOf() is NaN.
ptomato
force-pushed
the
extended-year-zero
branch
from
7b9112c
to
36ae072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Date.parse() and new Date(), representations of the year 0 as -000000
must not be accepted. In the case of Date.parse(), they should yield NaN,
and in the case of new Date(), they should yield an invalid Date object,
whose valueOf() is NaN.
See tc39/ecma262#2550