Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Array.prototype.includes and exponentiation features #3799

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

jedel1043
Copy link
Contributor

@jedel1043 jedel1043 commented Mar 22, 2023

While trying to use the features metadata to classify tests per ECMAScript edition, I realized there weren't features for the Array.prototype.includes function, nor the ** operator. Seeing that even ES6 features like class, let or const have their own features, it'd be more consistent to also have the same labeling for ES7 features.

This PR introduces the features Array.prototype.includes and exponentiation, and adds them to the corresponding tests.

@jedel1043 jedel1043 requested review from a team as code owners March 22, 2023 23:24
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, thanks

@ljharb ljharb requested a review from a team March 22, 2023 23:25
@Ms2ger Ms2ger merged commit 4a6439e into tc39:main Mar 23, 2023
@jedel1043 jedel1043 deleted the es7-feats branch March 23, 2023 14:47
bors bot pushed a commit to boa-dev/boa that referenced this pull request Mar 23, 2023
With tc39/test262#3799 merged we now have a way to separate ES7 tests from ES6 tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants