Added tests for invalid combinations of DurationFormat style options #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-allen
force-pushed
the
duration-format-style-conflicts
branch
from
6019c0c
to
c14049a
Compare
anba
approved these changes
Jan 10, 2024
Ms2ger
approved these changes
Jan 10, 2024
… for units following units using "numeric" or "2-digit" styles throws
Ms2ger
force-pushed
the
duration-format-style-conflicts
branch
from
c14049a
to
d5be81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of "long", "short", or "narrow" styles after units with "numeric" or "2-digit" styles should throw.
address tc39/proposal-intl-duration-format#64