Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return statement to throwsAsync callback #4090

Merged
merged 1 commit into from
May 18, 2024
Merged

Add missing return statement to throwsAsync callback #4090

merged 1 commit into from
May 18, 2024

Conversation

trflynn89
Copy link
Contributor

This callback is expected to return a thenable.

@trflynn89 @ljharb
Add missing return statement to throwsAsync callback
232dfc7 
This callback is expected to return a thenable.
@trflynn89 trflynn89 requested a review from a team as a code owner May 18, 2024 15:32
ljharb
ljharb approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks

@ljharb ljharb merged commit 232dfc7 into tc39:main May 18, 2024
8 checks passed
@trflynn89 trflynn89 deleted the promise_try_throws branch May 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trflynn89 @ljharb