-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DON'T SQUASH] Update params trailing comma tests #911
Conversation
cc @littledan |
…mma-arguments.js. Fixes tc39gh-822 Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
these tests are invalid. I'm fixing this PR soon function* f1() {
length = arguments.length;
};
f1(1,).next(); this has no connection with the trailing commas on the parameters list, but the arguments object and how the length is formed to correspond the given arguments list. Instead of adding this extra case, I'm removing all the |
In the meanwhile, I need to search for tests asserting the well formed arguments.length |
97ee0d0
to
c017b42
Compare
|
4219c1b
to
7522a29
Compare
I can add more cases but that would create more and more files and it's becoming way larger on every new addition. I suggest we follow up with new PRs to have easier reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some pretty dense stuff, but I read over all the .template
and .case
files, nothing stands out to me, the info blocks seem to match up, etc.
I'd still prefer if @littledan, @rwaldron, or someone else would take a good look here (even if after we merge it)
these tests will open the way for me to add more stuff on async generators, early errors, etc. I'll have this merged but already assuming the responsibility to fix anything else we find wrong. |
Closes #822