Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability for the user to resize the panel height #2

Closed
tcarlsen opened this issue Mar 17, 2014 · 8 comments
Closed

add the ability for the user to resize the panel height #2

tcarlsen opened this issue Mar 17, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@tcarlsen
Copy link
Owner

at the moment we only have a max-height, It would be nice if the user had the ability to resize the panel by dragging the top

@fangel
Copy link
Contributor

fangel commented Mar 25, 2014

Agreed. That would be rather cool.

@tcarlsen tcarlsen added this to the v1.1.0 milestone Apr 4, 2014
@joefitzgerald
Copy link
Contributor

I would like max-height to be something that can be expressed as a percentage on initialization of the MessagePanelView. It should be resizable for all percentages < 100% (at 100% the pane should be used to resize instead) and it should default to collapsing to the available content's size if that content occupies less than the max-height percentage.

25% sounds like a nice default percentage, assuming the panel collapses to available content by default.

@tcarlsen
Copy link
Owner Author

tcarlsen commented Apr 7, 2014

We need to be able to return this value to the package so it can be stored in a config file, so the user don't have to resize every single time they use the package

@joefitzgerald
Copy link
Contributor

Should storing defaults about the panel be something that is done once for all packages that use it, or once per package that use it?

@tcarlsen
Copy link
Owner Author

tcarlsen commented Apr 7, 2014

I believe we just should return the value to the package and then let it up to the package developer how to use this value.

I don't see us storing the value over all packages, where will be packages where you what to see more lines then in other packages

@joefitzgerald
Copy link
Contributor

👍

@tcarlsen
Copy link
Owner Author

moving this to milestone 1.2.0, we need to release 1.1.0

@tcarlsen tcarlsen modified the milestones: v1.2.0, v1.1.0 May 22, 2014
tcarlsen added a commit that referenced this issue Feb 10, 2015
@tcarlsen
Copy link
Owner Author

#62 should add this functionality ecept the (send the value back to the package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants