Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding resize ability #62

Merged
merged 2 commits into from
Feb 10, 2015
Merged

adding resize ability #62

merged 2 commits into from
Feb 10, 2015

Conversation

tcarlsen
Copy link
Owner

fixes issue #2

@tcarlsen
Copy link
Owner Author

please review @joefitzgerald

@@ -2,6 +2,7 @@
"indent": 2,
"node": true,
"predef": {
"atom": true
"atom": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indent?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope just adding document as a global. Using it now

@joefitzgerald
Copy link
Contributor

LGTM. I particularly like that max height can now be something that is relative to the viewport instead of a pixel-based measurement. 👍

@tcarlsen tcarlsen merged commit d938040 into v1.2.0 Feb 10, 2015
@tcarlsen tcarlsen deleted the issue-2 branch February 10, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants