Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS/BSD compatiblity #9

Merged
merged 3 commits into from
Feb 8, 2015
Merged

MacOS/BSD compatiblity #9

merged 3 commits into from
Feb 8, 2015

Conversation

neocturne
Copy link
Contributor

Let's hope there aren't any more incompatible qsort_r definitions...

@tcatm
Copy link
Owner

tcatm commented Feb 8, 2015

exit_error() should still allow format strings like error() does.

@neocturne
Copy link
Contributor Author

I tried not to introduce unnecessary code, the usage message was the only place where the format string was actually used.

Would you be okay with a macro definition, like in http://git.openwrt.org/?p=openwrt.git;a=commitdiff;h=76dde10b2061b8fedf88c38712fc054219a934d9 ?

@tcatm
Copy link
Owner

tcatm commented Feb 8, 2015

The macro looks fine.

@neocturne
Copy link
Contributor Author

Updated. I've found an issue with the macro (it doesn't to the right thing when errnum == 0), so I've replaced it with a proper function.

@tcatm tcatm merged commit 7b0e3b5 into tcatm:master Feb 8, 2015
@tcatm tcatm mentioned this pull request Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants