Skip to content

Commit

Permalink
install-deps.sh: download wheel using 'pip wheel'
Browse files Browse the repository at this point in the history
otherwise we will fail to install the build dependencies of
`lazy-object-proxy` from the wheelhouse. as `lazy-object-proxy` does not
add `setuptools_scm` in its `setup.py`, instead it lists
`setuptools_scm` in `setup.cfg` and `pyproject.toml` as a `build-system`
requires. but unfortunately, `pip download` only downloads the
install/run-time dependencies at this moment. and `lazy-object-proxy`
does not offer binary package for at least python2.7.

ideally, `pip download` should collects its dependencies like

Collecting setuptools_scm>=3.3.1 (from lazy-object-proxy->astroid<3,>=2.2.0->pylint->-r requirements-lint.txt (line 1))

so we need to use `pip wheel` do download build-time dependencies

see also pypa/pip#6222

Signed-off-by: Kefu Chai <kchai@redhat.com>
  • Loading branch information
tchaikov committed Aug 26, 2019
1 parent a576f9b commit 3562504
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install-deps.sh
Expand Up @@ -501,7 +501,7 @@ find . -name tox.ini | while read ini ; do
for interpreter in python2.7 python3 ; do
type $interpreter > /dev/null 2>&1 || continue
activate_virtualenv $top_srcdir $interpreter || exit 1
populate_wheelhouse "download -d $wip_wheelhouse" $require $constraint || exit 1
populate_wheelhouse "wheel -w $wip_wheelhouse" $require $constraint || exit 1
done
mv $wip_wheelhouse wheelhouse
md5sum $require_files $constraint_files > $md5
Expand Down

0 comments on commit 3562504

Please sign in to comment.