Skip to content

Commit

Permalink
ceph-disk: --no-mon-config
Browse files Browse the repository at this point in the history
Some of these cases make sense to fetch mon configs, but we are deprecating
ceph-disk anyway, and the tests currently make use of ceph-disk in places
that do not have a mon_host defined via a ceph.conf or other environment.
This avoids breaking those test cases without any real impact on users
(which will either use ceph-volume or presumably remain in a legacy config
environment).

Signed-off-by: Sage Weil <sage@redhat.com>
  • Loading branch information
liewegas committed Mar 6, 2018
1 parent 11e287c commit a095ec8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/ceph-disk/ceph_disk/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,7 @@ def get_conf_with_default(cluster, variable):
out = _check_output(
args=[
'ceph-osd',
'--no-mon-config',
'--cluster={cluster}'.format(
cluster=cluster,
),
Expand Down Expand Up @@ -1544,6 +1545,7 @@ def check_journal_reqs(args):
log_file = "/var/log/ceph/$cluster-osd-check.log"
_, _, allows_journal = command([
'ceph-osd', '--check-allows-journal',
'--no-mon-config',
'-i', '0',
'--log-file', log_file,
'--cluster', args.cluster,
Expand All @@ -1552,6 +1554,7 @@ def check_journal_reqs(args):
])
_, _, wants_journal = command([
'ceph-osd', '--check-wants-journal',
'--no-mon-config',
'-i', '0',
'--log-file', log_file,
'--cluster', args.cluster,
Expand All @@ -1560,6 +1563,7 @@ def check_journal_reqs(args):
])
_, _, needs_journal = command([
'ceph-osd', '--check-needs-journal',
'--no-mon-config',
'-i', '0',
'--log-file', log_file,
'--cluster', args.cluster,
Expand Down Expand Up @@ -3172,6 +3176,7 @@ def mkfs(
command_check_call(
[
'ceph-osd',
'--no-mon-config',
'--cluster', cluster,
'--mkfs',
'-i', osd_id,
Expand All @@ -3186,6 +3191,7 @@ def mkfs(
command_check_call(
[
'ceph-osd',
'--no-mon-config',
'--cluster', cluster,
'--mkfs',
'-i', osd_id,
Expand Down Expand Up @@ -4133,6 +4139,7 @@ def get_space_osd_uuid(name, path):
out = _check_output(
args=[
'ceph-osd',
'--no-mon-config',
'--get-device-fsid',
path,
],
Expand Down

0 comments on commit a095ec8

Please sign in to comment.