-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a patch fails during an upgrade, the error log is too hard to understand #361
Comments
@odelcroi with the new script merge_patchs.sh , I think we can close this issue |
when --exit-on-fail is removed, the patch fails silently but the log is not easier to read |
No, this error happens when applying the patch, not merging them |
One cause is that patch-package is not logging the right patch-dir, so we cannot tell which patch has errored. |
... and the corresponding fix for tchap-web : #683 This is a partial fix : postinstall seems to eat the logs in various ways, and sometimes it will output the patch-package log, in which case this fix will help (we'll get the right info from the log). When all logs are eaten by postinstall, it doesn't help. (a better fix is to stop postinstall from eating logs...) |
looks like #684 is a fix ! 🥳 |
When we upgrade element-web, and run "yarn install", the postinstall runs after yarn install, which applies patches. We expect some patches to break, this is normal since matrix-react-sdk and matrix-js-sdk can have changed.
In this case, we want the postinstall to crash and explain why it is crashing.
Expected :
The log explains clearly what happened : the break comes from patch-package, and the patch that failed is .
Obtained :
The log messages from "apply_patches.sh" are missing, which makes the error hard to track down.
Notes :
The text was updated successfully, but these errors were encountered: