Remove postinstall package, use the native yarn lifecycle script instead #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies, otherwise build fails. Not sure why it is not there already.
mcalinghee
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra dependency we are using (postinstall-postinstall) is for running the postinstall script after
yarn remove < mypackage >.See https://www.npmjs.com/package/postinstall-postinstall
We just need to run the postinstall script after
yarn install(right?) so we can just use the normal lifecycle of yarn, and remove the extra dependency.May help for #361 by logging properly when the postinstall script fails.