-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the admin convert a forum into a private room #617
base: develop_tchap
Are you sure you want to change the base?
Let the admin convert a forum into a private room #617
Conversation
return this.http.authedRequest(Method.Put, path, undefined, content); | ||
} | ||
|
||
+ /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be outside of the matrix-js-sdk?
PosthogTrackers.trackInteraction("WebRoomSettingsLeaveButton", ev); | ||
}; | ||
|
||
+ /* :TCHAP: Add button to change forum to private room if user is admin */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be outside of the matrix-react-sdk
C'est tjs d'actualité ca ? |
if (filter) { | ||
params.filter = JSON.stringify(filter); | ||
} | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unecessary add line break
We need to double check the implementation and add tests BUT it is not a huge priority as this use case arose only once. |
Cf. issue #363
To reproduce :
NB : I had trouble updating the list of rooms (outside of our component) so that the green forum icon of our newly turned private room would turn into a red lock icon. It is only a frontend problem, because I added a request to update the room status and it shows when I refresh the page. So my solution was to refresh the page with javascript. If you know of a better solution in the existing matrix code, please let me know :) In this component:
NB : the way I check that the user is an admin of the room is by verifying their powerLevel (100 as an admin, 0 as a regular user).