Let the admin convert a forum into a private room #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odelcroi
reviewed
Jun 29, 2023
| return this.http.authedRequest(Method.Put, path, undefined, content); | ||
| } | ||
|
|
||
| + /** |
There was a problem hiding this comment.
can it be outside of the matrix-js-sdk?
odelcroi
reviewed
Jun 29, 2023
| PosthogTrackers.trackInteraction("WebRoomSettingsLeaveButton", ev); | ||
| }; | ||
|
|
||
| + /* :TCHAP: Add button to change forum to private room if user is admin */ |
There was a problem hiding this comment.
can it be outside of the matrix-react-sdk
|
C'est tjs d'actualité ca ? |
odelcroi
reviewed
Nov 2, 2023
| if (filter) { | ||
| params.filter = JSON.stringify(filter); | ||
| } | ||
| + |
|
We need to double check the implementation and add tests BUT it is not a huge priority as this use case arose only once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue #363
To reproduce :
NB : I had trouble updating the list of rooms (outside of our component) so that the green forum icon of our newly turned private room would turn into a red lock icon. It is only a frontend problem, because I added a request to update the room status and it shows when I refresh the page. So my solution was to refresh the page with javascript. If you know of a better solution in the existing matrix code, please let me know :) In this component:
NB : the way I check that the user is an admin of the room is by verifying their powerLevel (100 as an admin, 0 as a regular user).