[dist] Fix coveralls build issue #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decompil3d
changed the title
Merged
|
@tchellomello mind taking a look and merging this and the 0.7.0 PR + publishing to PyPi? I'd love to get this new version added to Home Assistant so I can control my Ring landscape lights. Thanks! |
|
Outstanding @decompil3d !! Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is screwy with coveralls in
0.7.0branch PR.Going to try swapping to their GH Action to see if that helps.Will PR tomasterfirst and we can rebase the0.7.0branch accordingly.Looks like this is a known issue in the
coveralls-pythonpackage, and just adding the--serviceparam fixes it.