Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.0.0 Release Notes #251

Closed
davidmezzetti opened this issue Jan 12, 2021 · 4 comments
Closed

Update 3.0.0 Release Notes #251

davidmezzetti opened this issue Jan 12, 2021 · 4 comments

Comments

@davidmezzetti
Copy link

Thank you for the great work on this package.

Upon running a build today on GitHub actions, coveralls.io submission failed with a 422 Client Error: Unprocessable Entity error when submitting to coveralls.io.

The release notes look to have a typo (it says to set service-name vs service) on the command to override the service name.

With my GitHub actions build I had to run:

coveralls --service=github

When setting this option, the submission to coveralls started working again.

@TheKevJames
Copy link
Owner

Thanks for the bug report! And special thanks to @icemac for fixing this in #250. Both the release notes and the docs have now been updated. Sorry for any inconvenience!

@TheKevJames TheKevJames pinned this issue Jan 13, 2021
@TheKevJames TheKevJames unpinned this issue Jan 13, 2021
lukasberbuer added a commit to vallen-systems/pyWaveLine that referenced this issue Jan 14, 2021
@TimoRoth
Copy link
Contributor

Isn't the actual issue here that running in Github Actions is no longer properly auto-detected, and not the documentation about the service name being wrong?

@davidmezzetti
Copy link
Author

There is a pinned issue here - #252

Sounds like there is no known solution for auto detection at this time.

@TheKevJames
Copy link
Owner

Yeah, the big issue is that we can autodetect Github Actions, but we can't autodetect which service name Github Actions needs for this specific run. As far as we can tell at this point, the only option is for users to set the explicit name if their usecase requires a non-default service name.

pylipp added a commit to pylipp/financeager that referenced this issue Jan 15, 2021
joke2k added a commit to joke2k/faker that referenced this issue Jan 16, 2021
BrianJKoopman added a commit to simonsobs/socs that referenced this issue Jan 19, 2021
v3.0.0 of coveralls-python now requires `--service` be specified for things to
work with Github Actions. See [1].

[1] - TheKevJames/coveralls-python#251
BrianJKoopman added a commit to simonsobs/so3g that referenced this issue Jan 19, 2021
v3.0.0 of coveralls-python now requires `--service` be specified for things to
work with Github Actions. See [1].

[1] - TheKevJames/coveralls-python#251
BrianJKoopman added a commit to simonsobs/ocs that referenced this issue Jan 19, 2021
v3.0.0 of coveralls-python now requires `--service` be specified for things to
work with Github Actions. See [1].

[1] - TheKevJames/coveralls-python#251
wannaphong added a commit to PyThaiNLP/pythainlp that referenced this issue Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants