No double message on end of stream (#105)

tclaus · May 20, 2023 · 81ecad2 · 81ecad2
1 parent 0c5aa9f
commit 81ecad2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/app/assets/stylesheets/stream.scss b/app/assets/stylesheets/stream.scss
@@ -104,6 +104,10 @@
   }
 }
 
+.stream_pagination_controls {
+  display: none;
+}
+
 .opengraph-container {
   width: 100%;
   background-color: #f0f0f0;

diff --git a/app/controllers/streams_controller.rb b/app/controllers/streams_controller.rb
@@ -24,7 +24,7 @@ def local_public; end
 
   private
 
-  def stream_responder(stream_builder=nil)
+  def stream_responder(stream_builder)
     @stream_builder_object = stream_builder.new(current_user)
     @pagy, @stream = pagy_countless(@stream_builder_object.stream_posts)
     respond_to do |format|

diff --git a/app/views/streams/_stream_elements.html.haml b/app/views/streams/_stream_elements.html.haml
@@ -1,5 +1,3 @@
 = turbo_stream_from :posts
 - @stream.each do |post|
-  = render partial: "streams/stream_element_container", locals: {post: PostPresenter.new(post, current_user)}
-- if @stream.empty?
-  = render "streams/end_of_stream"
+  = render partial: "streams/stream_element_container", locals: {post: PostPresenter.new(post, current_user)}
diff --git a/app/views/streams/_stream_flow.html.haml b/app/views/streams/_stream_flow.html.haml
@@ -1,6 +1,8 @@
 %div{data: {controller: "infinite-scroll"}}
   %div{data: {infinite_scroll_target: "entries"}}
     = render partial: "streams/stream_elements", locals:{stream: stream}
-  %div{data:{infinite_scroll_target: "pagination"}}
+    - if stream.empty?
+      = render "streams/end_of_stream"
+  %div{data:{infinite_scroll_target: "pagination"}, class: "stream_pagination_controls"}
     - if @pagy.vars[:items]>= @stream.size
       = countless_stream_next_tag(@pagy)