Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just release without files #118

Merged
merged 2 commits into from
Sep 16, 2019
Merged

just release without files #118

merged 2 commits into from
Sep 16, 2019

Conversation

roschaefer
Copy link
Contributor

@roschaefer roschaefer commented Sep 15, 2019 •
edited
Loading

fix #111

Todo

  • Decide if we want to make PATH part of the options. That would be simpler but would also break the current API as you have to put the options in front of TAG.

@roschaefer
Copy link
Contributor Author

@tcnksm @Songmu Travis CI is missing $GITHUB_TOKEN, isn't it?

@Songmu
Copy link
Collaborator

Songmu commented Sep 16, 2019

Thanks. I'll merge it.

On TravisCI the encrypted environment variables are not available for pull requests from forks due to security risks.

Please note that encrypted environment variables are not available for pull requests from forks.
https://docs.travis-ci.com/user/encryption-keys/

As a result, the tests on pull request always fails. We recognize this as a problem.

@Songmu Songmu merged commit 4b1c4f7 into tcnksm:master Sep 16, 2019
@Songmu Songmu changed the title 111 release without files just release without files Sep 16, 2019
Songmu added a commit that referenced this pull request Sep 16, 2019
@Songmu
Checking in changes prior to tagging of version v0.13.0
d43a5d2 
## [v0.13.0](v0.12.2...v0.13.0) (2019-09-16)

* Show the exact `gofmt` command in README [#117](#117) ([roschaefer](https://github.com/roschaefer))
* just release without files [#118](#118) ([roschaefer](https://github.com/roschaefer))
* Fix typo [#114](#114) ([roschaefer](https://github.com/roschaefer))
@roschaefer
Copy link
Contributor Author

OK, cool! What about creating a separate Github account which has permissions for just one repository and publish that token? That would be an alternative for #116 you could simply check $GITHUB_TOKEN into source code and we would keep the hard-coded TestRepo and TestOwner configurations.

@roschaefer roschaefer deleted the 111_release_without_files branch September 16, 2019 08:56
@roschaefer
Copy link
Contributor Author

Hm, I guess publishing a $GITHUB_TOKEN would also enable people to create new repositories with that token? Maybe not the best idea.

@Songmu
Copy link
Collaborator

Songmu commented Sep 16, 2019

Released as v0.13.0.

roschaefer added a commit to Human-Connection/Human-Connection that referenced this pull request Sep 16, 2019
@roschaefer
Relase without any artifacts
f5b7130 
I contributed to `ghr` here:
tcnksm/ghr#118

Now after `ghr` does not need any artifacts to create a file, we can
stop uploading archives. (Use the default archives provided by Github)
@roschaefer roschaefer mentioned this pull request Sep 16, 2019
Merged
1 task
@Tirokk Tirokk mentioned this pull request Oct 5, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releases with no files should be allowed
2 participants
@roschaefer @Songmu