Rails 5 AR workflow addition. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merqlove
force-pushed
the
feature/custom-parent-classes
branch
from
d2f6996
to
5fe8253
Compare
| @@ -3,12 +3,14 @@ module FollowerLib | |||
|
|
|||
| private | |||
|
|
|||
| DEFAULT_PARENTS = [ActiveRecord::Base] | |||
There was a problem hiding this comment.
Can you set the DEFAULT_PARENTS to ApplicationRecord if it's Rails 5?
|
This is great work. Thank you for contributing. |
merqlove
force-pushed
the
feature/custom-parent-classes
branch
2 times, most recently
from
4acdee8
to
f4e340e
Compare
merqlove
force-pushed
the
feature/custom-parent-classes
branch
from
f4e340e
to
e14a1e4
Compare
|
Changed logic back for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to setup custom parent classes (i.e.
ApplicationRecord). Tested with rails5 branch.