-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We have to use mocha from the CDN, browserify cant build mocha see
- Loading branch information
Wolfram Kriesing
committed
Feb 18, 2015
1 parent
c3df7d2
commit 92c7394
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
require('mocha'); | ||
var expect = require('referee/lib/expect'); | ||
var should = require('should'); | ||
|
||
|
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wolframkriesing Out of curiosity, how did you minify mocha? I'm looking to do the same to run mocha inside Nashorn as a single script. Seems like you need to do a bunch of work arounds to do this.
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the minification takes place here.
https://github.com/tddbin/tddbin-frontend/blob/master/package.json#L13
does that help?
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, actually, as the commit says: I seemed not to have been able to minify it :/
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah where did you find this then?
cdnjs.cloudflare.com/ajax/libs/mocha/2.1.0/mocha.min.js
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I just tried it, but i dont remember :)
92c7394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha. Sounds good. I think I'll do the same.