Google 2fa fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eszkadev
commented
May 23, 2016
eszkadev
commented
- parser changed to work with new challenge page structure (tdf#87938)
- supported aborting in the auth code provider
- updated gdrive test
| if ( strcmp((char*)action, "/signin/challenge") != 0 | ||
| && strcmp((char*)action, "/signin/selectchallenge") != 0 | ||
| && xmlStrlen(action) > 0 ) | ||
| bool bChallengePage = ( xmlStrlen( action ) > 0 ) |
There was a problem hiding this comment.
I don't see any point in the xmlStrlen check. If action is "", the comparison will fail anyway.
| @@ -33,6 +33,11 @@ | |||
| #include "oauth2-providers.hxx" | |||
| #include "http-session.hxx" | |||
|
|
|||
| #define CHALLENGE_PAGE_ACTION "/signin" | |||
There was a problem hiding this comment.
Well, what I had on mind was something like
#define STR_LIT_WITH_LEN(str) str, (sizeof(str) - 1)
, but this is good enough...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.