Fix font resolution if style misses text properties #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, I (or some other volunteer) will certainly review and merge it (or discuss in case of suggested changes) before the release. Have a nice Friday the 13th |
svanteschubert
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
after some time I stumbled over another bug. This was about style resolution.
Please review and merge if you like.
BTW: I found a lot of duplication between
CellStyleHandlerandParagraphStyleHandlerbut was not able to judge about the technical details. I just harmonized code as much as possible. Thus one can see differences more easy.Best Regards
Stefan