Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_MINDEPTH_INRANGE #107

Open
iDigBioBot opened this issue Jan 5, 2018 · 17 comments
Open

TG2-VALIDATION_MINDEPTH_INRANGE #107

iDigBioBot opened this issue Jan 5, 2018 · 17 comments
Labels
Conformance CORE TG2 CORE tests Parameterized Test requires a parameter SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 04b2c8f3-c71b-4e95-8e43-f70374c5fb92
Label VALIDATION_MINDEPTH_INRANGE
Description Is the value of dwc:minimumDepthInMeters within the Parameter range?
TestType Validation
Darwin Core Class Location
Information Elements ActedUpon dwc:minimumDepthInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:minimumDepthInMeters is EMPTY, or the value is not interpretable as number greater than or equal to zero; COMPLIANT if the value of dwc:minimumDepthInMeters is within the range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINDEPTH_INRANGE
Parameter(s) bdq:minimumValidDepthInMeters
bdq:maximumValidDepthInMeters
Source Authority bdq:minimumValidDepthInMeters default="0"
bdq:maximumValidDepthInMeters default="11000"
Specification Last Updated 2023-09-18
Examples [dwc:minimumDepthInMeters="1": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumDepthInMeters is in range"]"
[dwc:minimumDepthInMeters="12000": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumDepthInMeters is not in range"]
Source ALA, GBIF
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes The Challenger Deep in the Mariana Trench is the deepest known point in Earth's oceans at 10,994 meters. We have rounded up bdq:maximumValidDepthInMeters.
@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Minumum depth should also be less than 11000m, and max depth should also be greater than or equal to 0 meters, as only a single depth might be provided. @pz, feels like likeliness rather than conformance, as it isn't a format problem, just the compliance of a range with expected reality.

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Aren't valid depth values less than zero possible, given the vertical datum? Near shore samples could be collected at a depth of -1 meter, relative to a horizontal datum of mean low tide, when collected under water at high tide. "below the local surface" leaves itself open to interpreation as relative to the water surface, or as relative to a particular horizontal datum defining the local surface. In collections made in nearshore environments, depths in reference to a defined horizontal datum as well as the actual water surface at the time of collection are both likely.

@chicoreus
Copy link
Collaborator

As defined in Darwin Core, dwc:minimum/maximumDepthInMeters can not be less than 0, as it is defined in reference to the local surface.

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 17, 2018
@Tasilee Tasilee changed the title TG2-VALIDATION_MINDEPTHMAXDEPTH_OUTOFRANGE TG2-VALIDATION_MINDEPTH-MAXDEPTH_OUTOFRANGE Oct 1, 2018
@ArthurChapman ArthurChapman added the Parameterized Test requires a parameter label May 16, 2019
@Tasilee Tasilee changed the title TG2-VALIDATION_MINDEPTH-MAXDEPTH_OUTOFRANGE TG2-VALIDATION_MINDEPTH_OUTOFRANGE Aug 26, 2020
@Tasilee
Copy link
Collaborator

Tasilee commented Aug 26, 2020

This was originally a test for both dwc:minimumdepthInMeters and dwc:maximumDepthInMeters but has been split into separate tests after raising the issue today.

ArthurChapman added a commit that referenced this issue Oct 9, 2020
In accord with #189 added test data file for #107
@albenson-usgs
Copy link

Two things on this one and #187

  1. Is there interest to use what OBIS does with GEBCO to detect values out of range? (Example)
  2. What should data providers do for marine species that spend all or some of their time above the surface of the water? Seabirds, polar bears, penguins. Or species that are not always submerged such as intertidal species like crabs, mussels, limpets.

@Tasilee
Copy link
Collaborator

Tasilee commented Nov 2, 2021

Fair point @albenson-usgs but this could be handled by the Parameters in implementations?

@tucotuco
Copy link
Member

tucotuco commented Nov 4, 2021

  1. What should data providers do for marine species that spend all or some of their time above the surface of the water? Seabirds, polar bears, penguins. Or species that are not always submerged such as intertidal species like crabs, mussels, limpets.

According to Darwin Core and Georeferencing Best Practices (https://docs.gbif.org/georeferencing-best-practices/1.0/en/#water-depth), depths may not be negative (i.e., above a water surface). For such situations (taxon irrelevant), the terms for minimumDistanceAboveSurface and maximumDistanceAboveSurface are recommended.

DwCElevationDepthDistanceAboveSurface

@Archilegt
Copy link

Archilegt commented Nov 5, 2021

@tucotuco , I really like that image, but it contains incorrect statements. For coring cases, such as those represented on the top right and bottom right figures, the statement "distancia sobre la superficie" makes no sense. In Spanish, we would refer those as "distancia bajo la superficie (del suelo /del fondo)". On the other hand, using surface / superficie alone is ambiguous, as "superficie del suelo" and "superficie del fondo (lacustre, marino, etc.)" are both surfaces but refer to different cases.

@Archilegt
Copy link

Archilegt commented Nov 5, 2021

I looked at the material in English. I think that it was unfortunate to address "Distance above Surface" rather than "Distance relative to Surface". I am a soil biologist / myriapodologist. The soil surface is my reference level. There are occurrences above the soil surface, with positive values, and occurrences under the soil surface, with negative values. If we are going to have just one term for this sort of occurrences, then the term should not be "above" but "relative to", and allow both positive and negative values.
There is the same problem with elevation. When we give elevation in meters m (or any other metric) above sea level (a.s.l.), and then we write -20 m a.s.l., the statement is not semantic anymore. It is not semantically "elevation", and it is not "above" the sea level. I see elevation and depth as natural, semantic pairs, relative to a surface, with positive and negative values, respectively. Same for above the surface and under the surface.

@tucotuco
Copy link
Member

tucotuco commented Nov 8, 2021

@Archilegt As you've noticed by reviewing the English material, it is not a question of language. I understand what you say about the concept being relative to a surface, but the choice of term name and how the values are encoded is deliberate, so that one can indicate that the value IS relative to a datum, and furthermore in which direction. That much should be clear from the definitions. The problem really lies in using the word "distance", which is a positive scalar, when the concept really signifies a vector. So, I respectfully disagree with your assessment that the term should be "relative to" rather than "above". The alternative would be to add two new terms to hold the direction, which seems excessive when it can be easily done with the sign of the scalar value and the documentation of the convention. The same holds for elevation (for an example see any Wikipedia entry for a feature that has an elevation, such as https://en.wikipedia.org/wiki/Death_Valley).

@Tasilee Tasilee changed the title TG2-VALIDATION_MINDEPTH_OUTOFRANGE TG2-VALIDATION_MINDEPTH_INRANGE Mar 22, 2022
@ArthurChapman
Copy link
Collaborator

Added "of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive" for consistency with other related tests

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Sep 5, 2022
…to current specification and method name with comments, notes, and minimal unit test.
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Sep 6, 2022
 VALIDATION_MINDEPTH_INRANGE to match current specification.  Also aligning tdwg/bdq#187 VALIDATION_MAXDEPTH_INRANGE with the same rejection out of hand of negative values, though the current test specifications are inconsistent in these two cases.
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 8, 2022

Amended ER to

INTERNAL_PREREQUISITES_NOT_MET if dwc:minimumDepthInMeters is EMPTY, or the value is not interpretable as number greater than or equal to zero; COMPLIANT if the value of dwc:minimumDepthInMeters is within the range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT

@Tasilee
Copy link
Collaborator

Tasilee commented Jun 13, 2023

Restructured Parameter(s) and Source authority

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 18, 2023
…st current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#107 VALIDATION_MINDEPTH_INRANGE   Adding ProvidesVersion annotations.   Removing now empty file stubs for checked methods.  Adding to unit test.
@ymgan
Copy link

ymgan commented Sep 9, 2023

Hi, I would like to double check to confirm that depths MUST not be negative under any circumstances, correct? Thanks a lot!

@tucotuco
Copy link
Member

tucotuco commented Sep 9, 2023

According to georeferencing best practices, that is correct. Depth is defined as below a (water) surface.

@ymgan
Copy link

ymgan commented Sep 9, 2023

Great!! Thank you so much John!

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance CORE TG2 CORE tests Parameterized Test requires a parameter SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Development

No branches or pull requests

8 participants