Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_OCCURRENCESTATUS_NOTEMPTY #117

Open
godfoder opened this issue Jan 17, 2018 · 6 comments
Open

TG2-VALIDATION_OCCURRENCESTATUS_NOTEMPTY #117

godfoder opened this issue Jan 17, 2018 · 6 comments
Labels
Completeness CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@godfoder
Copy link
Contributor

godfoder commented Jan 17, 2018

TestField Value
GUID eb4a17f6-6bea-4cdd-93dd-d5a7e9d1eccf
Label VALIDATION_OCCURRENCESTATUS_NOTEMPTY
Description Is there a value in dwc:occurrenceStatus?
TestType Validation
Darwin Core Class Occurrence
Information Elements ActedUpon dwc:occurrenceStatus
Information Elements Consulted
Expected Response COMPLIANT if dwc:occurrenceStatus is not EMPTY; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions OCCURRENCESTATUS_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:occurrenceStatus="?": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:occurrenceStatus is not EMPTY"]
[dwc:occurrenceStatus="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:occurrenceStatus is EMPTY"]
Source ALA
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
@ArthurChapman ArthurChapman added TG2 Validation SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT OTHER and removed SPACE labels Jan 17, 2018
@iDigBioBot iDigBioBot changed the title TG2-VALIDATION_OCCURRENCESTATUS_NULL TG2-VALIDATION_OCCURRENCESTATUS_EMPTY Jan 29, 2018
@Tasilee Tasilee added Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. and removed Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT labels Mar 21, 2018
@Tasilee Tasilee added the Issue A potential issue label Aug 14, 2018
@Tasilee
Copy link
Collaborator

Tasilee commented Aug 14, 2018

Why did I put NOT_CORE? It seems a simple easy to test and useful FLAG right now. As a VALIDATION, it would also add meaningfully to #135 but it also shapes like a NOTIFICATION as per #58?

@ArthurChapman
Copy link
Collaborator

I think it was one of those that is empty 90% of the time so would create millions of flags. Thinking back - wasn't there some problem with how people were using occurrenceStatus (i.e. to be more than just Present/Absent? One, I guess, assumes if it is blank, then it is present. Because of this, I think we agreed that it shouldn't be CORE

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 14, 2018

This relates to an existing ALA test of the type we would call NOTIFICATION that says "occurrence status is empty so we are assuming "present". This still seems like a wise thing to me. Yes, it will be flagged a lot, but in this case (as we discussed in Gainesville) - sometimes we need to make a point :) "Please PUT THE OCCURRENCE STATUS IN!"

@Tasilee Tasilee changed the title TG2-VALIDATION_OCCURRENCESTATUS_EMPTY TG2-NOTIFICATION_OCCURRENCESTATUS_EMPTY Aug 15, 2018
@Tasilee Tasilee added Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT and removed Validation Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Aug 15, 2018
@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Aug 22, 2018

I believe this is a VALIDATION not a NOTIFICATION. However, because we have #75 I believe we can delete this one altogether as #75 states that if it is EMPTY then replace with "Present". In spite of @Tasilee's argument above - I think just having an Annotation that says something like "basisOfRecord was EMPTY and it has thus been assumed to be Present" I don't believe (especially in interests of keeping it Simple and the number of annotations as few as possible) I think this is redundant and thus NOT CORE

@Tasilee Tasilee changed the title TG2-NOTIFICATION_OCCURRENCESTATUS_EMPTY TG2-VALIDATION_OCCURRENCESTATUS_EMPTY Aug 22, 2018
@Tasilee Tasilee added Validation and removed Issue A potential issue labels Aug 22, 2018
@Tasilee
Copy link
Collaborator

Tasilee commented Aug 22, 2018 via email

Tasilee added a commit that referenced this issue Oct 7, 2020
In accordance with #189, added testdata_VALIDATION_OCCURRENCESTATUS_EMPTY_#117.csv for #117
@Tasilee Tasilee changed the title TG2-VALIDATION_OCCURRENCESTATUS_EMPTY TG2-VALIDATION_OCCURRENCESTATUS_NOTEMPTY Mar 22, 2022
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Aug 29, 2022
…nimal unit tests for those tests. Implementations for tdwg/bdq#94 tdwg/bdq#58 tdwg/bdq#103 tdwg/bdq#99 tdwg/bdq#47 and tdwg/bdq#117 added utility class with method to test if empty.  Changing implemented methods to static.
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness CORE TG2 CORE tests OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Development

No branches or pull requests

5 participants