Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_PATHWAY_STANDARD #277

Open
ArthurChapman opened this issue Feb 8, 2024 · 12 comments
Open

TG2-VALIDATION_PATHWAY_STANDARD #277

ArthurChapman opened this issue Feb 8, 2024 · 12 comments
Labels
Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 8, 2024

TestField Value
GUID 5424e933-bee7-4125-839e-d8743ea69f93
Label VALIDATION_PATHWAY_STANDARD
Description Does the value of dwc:pathway occur in bdq:sourceAuthority?
TestType Validation
Darwin Core Class Occurrence
Information Elements ActedUpon dwc:pathway
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:pathway is EMPTY; COMPLIANT if the value of dwc:pathway is in the bdq:sourceAuthority; otherwise NOT_COMPLIANT.
Data Quality Dimension Conformance
Term-Actions PATHWAY_STANDARD
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}
Specification Last Updated 2024-02-09
Examples [dwc:pathway="transportStowaway": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:pathway has an equivalent in the bdq:sourceAuthority"]
[dwc:pathway="escapee": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:pathway does not have an equivalent in the bdq:sourceAuthority"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters.
@ArthurChapman ArthurChapman added TG2 Validation OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT VOCABULARY NEEDS WORK Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Conformance Parameterized Test requires a parameter labels Feb 8, 2024
@ArthurChapman
Copy link
Collaborator Author

Should be CORE see comments under #268

@Tasilee Tasilee added CORE TG2 CORE tests and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 9, 2024
@ArthurChapman
Copy link
Collaborator Author

The four tests (#277, #278, #268, #269) should be CORE (I have discussed this with Lee). Some reasons are

  • Invasive species are subject of the Convention on Biological Diversity Article 8(h) (https://www.cbd.int/idb/2009/about/cbd) and with a strong use case in the Cop 6 Decision last year VI/23 (https://www.cbd.int/decision/cop/default.shtml?id=7197)
  • These terms are recent additions to Darwin Core and are aspirational (we want all adding data follow the Standard)
  • There are good, well thought out vocabularies and APIs available
  • Apart from the CBD Use Case, there are good Use Case arguments given in Groom et al. (reference above)
  • There is no reason under our current criteria for excluding these tests from CORE

@chicoreus
Copy link
Collaborator

Edited comment from "will fail" to the more explicit "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. "

@chicoreus
Copy link
Collaborator

Source authority should be:

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 24, 2024

I agree @chicoreus - Changing Source Authority from

bdq:sourceAuthority default = "Darwin Core pathway" {[https://dwc.tdwg.org/list/#dwc_pathway]} {dwc:pathway vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 19, 2024

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/Pathway/concepts"?

@tucotuco
Copy link
Member

I think https://api.gbif.org/v1/vocabularies/Pathway/concepts is OK as a source authority because it actually has an API as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/pw/ and the GBIF API is expected to remain up to date with that.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "GBIF Pathway Vocabulary" [https://api.gbif.org/v1/vocabularies/Pathway]} {"dwc:pathway vocabulary API" [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

@tucotuco
Copy link
Member

This was correct before the change. Darwin Core has the formal recommended vocabulary.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Reverted Source Authority

@chicoreus
Copy link
Collaborator

See #275 (comment)

The GBIF API does not help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case.

@Tasilee
Copy link
Collaborator

Tasilee commented May 14, 2024

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY
Projects
None yet
Development

No branches or pull requests

4 participants