Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change term - associatedSequences #332

Closed
tucotuco opened this issue Apr 12, 2021 · 7 comments
Closed

Change term - associatedSequences #332

tucotuco opened this issue Apr 12, 2021 · 7 comments

Comments

@tucotuco
Copy link
Member

tucotuco commented Apr 12, 2021

Change term

  • Submitter: John Wieczorek
  • Justification (why is this change necessary?): Consistency and clarity
  • Proponents (who needs this change): Everyone

Current Term definition: https://dwc.tdwg.org/terms/#dwc:associatedSequences

Proposed new attributes of the term:

  • Term name (in lowerCamelCase): associatedSequences
  • Organized in Class (e.g. Location, Taxon): MaterialSample
  • Definition of the term: (unchanged): A list (concatenated and separated) of identifiers (publication, global unique identifier, URI) of genetic sequence information associated with the MaterialSample.
  • Usage comments (recommendations regarding content, etc.): Note that the ResourceRelationship class is an alternative means of representing associations, and with more detail. Recommended best practice is to separate the values in a list with space vertical bar space ( | ).
  • Examples: http://www.ncbi.nlm.nih.gov/nuccore/U34853.1, http://www.ncbi.nlm.nih.gov/nuccore/GU328060 | http://www.ncbi.nlm.nih.gov/nuccore/AF326093
  • Refines (identifier of the broader term this term refines, if applicable): None
  • Replaces (identifier of the existing term that would be deprecated and replaced by this term, if applicable): http://rs.tdwg.org/dwc/terms/version/associatedSequences-2017-10-06
  • ABCD 2.06 (XPATH of the equivalent term in ABCD or EFG, if applicable): DataSets/DataSet/Units/Unit/Sequences/Sequence/ID-in-Database + constant

Discussions around changes to relationshipOfResource (#194), around a new term relationshipOfResourceID (#186, #283), and changes to associatedOccurrences (Issue #324) suggest that a clarification should also be made in the associatedSequences usage notes. Specifically, the convention on list item separation and the reference to ResourceRelationship as an alternative means of capturing these data are recommended.

@baskaufs
Copy link

dwc:associatedSeqences does not have dwciri: analog, so no revision necessary in that namespace.

@tucotuco
Copy link
Member Author

Related issues are Issue #1, Issue #3, Issue #24 (reopened because of renewed interest), Issue #314, Issue #344, Issue #345, Issue #346, and Issue #347.

@afuchs1
Copy link

afuchs1 commented May 26, 2021

The Australasian Herbarium Information Systems Committee (HISCOM) considers moving attributes from Occurrence to MaterialSample premature given the Extended and Digital Specimen consultation that is occurring and the general conversation about the definition and scope of MaterialSample (#314).

Relates also to associatedSequences (#332), preparations (#346) and disposition (#347)

Regarding the usage note, associatedSequences differs from associatedOccurrences, associatedTaxa etc. In that it takes a list of URIs rather than a list of key–value pairs, so using the ResourceRelationship class instead does not add anything and in fact might make it harder for consumers to interpret and for aggregators to process the data. We suggest removing this usage note.

@EstebanMH-SiB
Copy link

We endorse this proposal for the change in usage comments on behalf of @SiBColombia.
We think that the change in the class is also logic, but maybe is better to wait for the results of the consultation as @afuchs1 proposses, just to be sure.

@tucotuco
Copy link
Member Author

tucotuco commented May 28, 2021

The Australasian Herbarium Information Systems Committee (HISCOM) considers moving attributes from Occurrence to MaterialSample premature given the Extended and Digital Specimen consultation that is occurring and the general conversation about the definition and scope of MaterialSample (#314).

In the case of a sequence, it necessarily must derive from a MaterialSample, so I see no risk in making that organizational change regardless of the Extended and Digital Specimen consultation. Can anyone realistically see any risk in this non-normative change for this term?

Relates also to associatedSequences (#332), preparations (#346) and disposition (#347)

Regarding the usage note, associatedSequences differs from associatedOccurrences, associatedTaxa etc. In that it takes a list of URIs rather than a list of key–value pairs, so using the ResourceRelationship class instead does not add anything and in fact might make it harder for consumers to interpret and for aggregators to process the data. We suggest removing this usage note.

The usage note does not even make the recommendation to use ResourceRelationship instead, it only points out that it is an alternative, which is still true, including that more detail can be added (contrary to the position that "it does not add anything"). Would a change in the usage note from "Note that the ResourceRelationship class is an alternative means of representing associations, and with more detail" to "Note that the ResourceRelationship class is an additional means of representing associations, and with more detail" alleviate the perception that the ResourceRelationship representation is somehow preferred?

@tucotuco tucotuco added the Task Group - Material Sample https://www.tdwg.org/community/osr/material-sample/ label Jun 2, 2021
@tucotuco
Copy link
Member Author

tucotuco commented Jun 2, 2021

This proposal has been labeled as 'Controversial' and in need of a task group to for resolution. It is no longer part of an active public review.

@tucotuco
Copy link
Member Author

This issue has been superseded by #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants