-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What behaviour should occur when all columns are hidden? #19
Comments
Before I commit to a position, I would like to know your reasoning behind having
Since |
Hi @rahl0b10, The idea behind this design is that we may want to generate a table for certain fields of a pre-existing type. In this case, we'd (indirectly) call the constructor on the type in it's entirety, before marking the For instance, we may want to do as follows:
And because we've hidden a column, we get the following:
Note that "Baboon" isn't printed. All the examples and tests contained in the repo use types created ad hoc, solely as vehicles for the data destined for the table. In real usage, these tables are much more likely to receive Hope this makes sense? |
Hi @tdwright , That does make sense, thank you! You couldn't do what I suggested above because we need the constructed object to set the Hide feature in the first place. In that case, I think I'd fall on the side of throwing a different exception. |
I think that it should throw a unique exception that provides a meaningful suggestion. |
Fixed in #49 |
Relating to #13 - what behaviour do we want to happen when a data type has public properties (thereby not triggering the exception added in #18), but where the resulting columns have all been manually hidden?
The text was updated successfully, but these errors were encountered: