Added safe mode option and url builder #23
Conversation
| None instead. | ||
| """ | ||
| return get_current_context(silent=True) | ||
| return context.obj.get("DEBUG") if (context := get_current_context(silent=True)) else False |
There was a problem hiding this comment.
This pattern of adding an object to the context and fetching it this way is repeated (and will be repeated again if the submit dry-run is ever fully implemented).
Maybe add a new util? JokesContext?
There was a problem hiding this comment.
Context can already be fetched from anywhere in the code via get_current_context.
We could add a method like this though:
def get_context_object(key: str, default: bool = False) -> bool:
return c.obj.get(key) if (c := get_current_context(silent=True)) else default
src/jokes/utils/urls.py
Outdated
| SUBMIT = "submit" | ||
|
|
||
|
|
||
| def format_params(dict: Mapping[str, Primitive]) -> str: |
There was a problem hiding this comment.
Passing params here and then calling the dict() method internally is possible, but it doesn't ensure the safety of the join, specifically the f"{k}={v}" since the pydantic dict method only requires a dict[str, Any].
So theoretically we could construct a parameter class that returns a dict of type dict[str, SomeComplexType] which would either break the query string or return something illegible.
closes #22