refactor: api for adjusting the order

[tea-artist]

1. Removes the API that sets order directly
2. Remove order from the return value
3. Set the position according to the anchor point
4. Automatic shuffling ensures that ordering can be performed repeatedly

[tranhuywin]

await this.prismaService.$tx(async () => {
  await Promise.all(views.map(async (view, i) => {
    await this.viewService.updateViewByOps(tableId, view.id, [
      ViewOpBuilder.editor.setViewProperty.build({
        key: 'order',
        newValue: i,
        oldValue: view.order,
      }),
    ]);
  }));
});

I think it should be like this. It would be better.

[tea-artist]

Thanks for review

A large number of concurrent operations in a single transaction will not yield much incremental benefit, and this is not a bottleneck

[tranhuywin]

I think it is a bottleneck, It will await sequence updateViewByOps
and when using Promise.all, it will await the longest updateViewByOps

[tea-artist]

First off, from the user's perspective, there won't be a large number of views, so the speed difference is almost imperceptible. However, if there really is a large quantity, the inherent overhead of numerous promises could actually slow things down. In another feature we implemented, we adopted the method of copying to a temporary table for bulk updates, which, after testing, resulted in a more than tenfold improvement in speed and is currently the fastest method we've found.

Another point worth mentioning is that we also support sqlite, which does not support concurrent writing. Attempting this in end-to-end (e2e) tests with sqlite has led to some strange errors.

[tea-artist]

I changed some of your code @caoxing9 , you might want to check out the new implementation

[caoxing9]

LGTM