Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: row order #473

Merged
merged 2 commits into from Mar 20, 2024
Merged

refactor: row order #473

merged 2 commits into from Mar 20, 2024

Conversation

tea-artist
Copy link
Contributor

@tea-artist tea-artist commented Mar 20, 2024 •
edited

  1. Remove recordOrder from the record snapshot.
  2. Add an API for updating record order （previously only via op by sharedb)
  3. Will not create the order index in every view by default.
  4. Auto index when the user doing drag / create record with order / manual sort actions.
  5. Auto suffering.
  6. Allowed to drag multiple records at once.

What are benefits
Creating a view in a big table is way faster.
Reduce index amount to save disk space.
Fixed unstable sequence issues

@tea-artist tea-artist marked this pull request as ready for review March 20, 2024 04:19
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2024 •
edited

Pull Request Test Coverage Report for Build 8354810300

Details

  • 194 of 588 (32.99%) changed or added relevant lines in 38 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 28.231%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/base/base-duplicate.service.ts 0 1 0.0%
apps/nestjs-backend/src/features/base/base.service.ts 0 1 0.0%
apps/nestjs-backend/src/features/field/field.service.ts 2 3 66.67%
apps/nestjs-backend/src/features/graph/graph.service.ts 1 2 50.0%
apps/nestjs-backend/src/features/calculation/reference.service.ts 3 5 60.0%
apps/nestjs-backend/src/features/record/open-api/record-open-api.controller.ts 0 2 0.0%
apps/nestjs-backend/src/features/table/open-api/table-open-api.service.ts 0 2 0.0%
packages/sdk/src/model/record/record.ts 1 3 33.33%
packages/sdk/src/model/table/table.ts 8 10 80.0%
apps/nestjs-backend/src/features/record/record-calculate/record-calculate.service.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/db-provider/postgres.provider.ts 1 27.54%
apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts 1 21.79%
Totals Coverage Status
Change from base Build 8341267774: 0.06%
Covered Lines: 25811
Relevant Lines: 91428
💛 - Coveralls

@tea-artist tea-artist merged commit fd0caa3 into develop Mar 20, 2024
8 checks passed
@tea-artist tea-artist deleted the refactor/row-order branch March 20, 2024 08:52
tea-artist added a commit that referenced this pull request Mar 20, 2024
@tea-artist @caoxing9
@boris-w @dammy001 @MichaelYuhe @Pengap @codesmith-emmy @zzjin @eltociear
release: v1.1.0-beta (#475)
9b9a2cf 
* feat: support excel import (#431)

* feat: support `csv` import

* perf: optimise import memory expend

* fix: `openapi` upload type error

* test: compatible ci attachment download

* feat: add import file icon

* feat: support `excel` import

feat: limit excel file size

refactor: rewrite import font-end

* chore: add `sheetjs` license

* feat: update import url validate strategy

* test: add excel import e2e

* feat: add logger in import records

* fix: type and lint error

* chore: replace axios to node-fetch in nestjs

* test: update import-table e2e

* test: update import-table delay time

* chore: delete `sheetjs` license

* feat: add analyze loading

* chore: export upload-panel component

* feat: integrate github login (#432)

* feat: integrate gitHub login

* feat: dynamic social auth module

* feat: add github auth env validation

* chore: remove electron (#438)

* feat: credit check (#436)

* feat: credit check

* test: exceed credit limit

* refactor: more appropriate email template structure (#437)

* chore: make pnpm automatically install the specified version of Node.js (#433)

* chore: remove nvm step

* fix: the error of copying and pasting empty content (#443)

* fix: the error of copying and pasting empty content

* ci: fixed node version

* ci: pnpm newline handling

* feat: compatible `tsv` import (#446)

* fix: rename link results in illegal data (#448)

* fix: unexpected horizontal lines on login page (#447)

* test: import test file save in tmp dir (#449)

* docs: add deploy on Zeabur in Readme (#451)

* docs: add deploy on Zeabur in Readme

* Update README.md

* Update README.md

* build:  image support `multi-platforms` & app image support `csp-open` (#445)

* build: app image support `csp-open`

* feat: docker image multi-platforms support

* fix: allow default db address (#461)

* feat: forgot password and setup new password (#452)

* feat: forgot password and setup new password

* chore: remove useless code

* fix: use instance test context creator

* fix: type error

* fix: sdk build config for *.spec.tsx

* fix: execute repeat when import upload (#464)

* fix: notify jump url & upgrade deps (#465)

* fix: notify jump url & upgrade deps

* feat: update `PUBLIC_DATABASE_PROXY` env

* fix: ensure interface-provided 'orderBy' parameter overrides view's default sort (#463)

* fix: ensure interface-provided 'orderBy' parameter overrides view's default sort

* fix: existence of identical fields sorted, with the later overwriting the earlier

* chore: signin error alerts

* feat: support google oatuh2 (#466)

* refactor: api for adjusting the order (#453)

* fix: i18n

* docs: star distribution

* refactor: view order

* refactor: view+table+base updateOrder

* feat: ci add `coverallsapp/github-action` (#468)

* feat: ci add `coverallsapp/github-action`

* fix: vitest `coverage.reporter` config (#469)

* fix: vitest `coverage.reporter` config

* chore(example): update dockers examples (#474)

* docs: Update header titles for consistency (#455)

* docs: add one-click deploy on sealos. (#462)

Signed-off-by: zzjin <tczzjin@gmail.com>

* chore: Update constants.ts (#457)

minor fix

* refactor: row order (#473)

* refactor: row order

* fix: sqlite test

---------

Signed-off-by: zzjin <tczzjin@gmail.com>
Co-authored-by: Mike <caoxing9@gmail.com>
Co-authored-by: Boris <boris2code@outlook.com>
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
Co-authored-by: Yuhang <2312744987@qq.com>
Co-authored-by: Pengap <penganpingprivte@gmail.com>
Co-authored-by: emmanuel <154705254+codesmith-emmy@users.noreply.github.com>
Co-authored-by: zzjin <zzjin@users.noreply.github.com>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
@tea-artist tea-artist changed the title refactor: row order 💣 refactor: row order Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tea-artist @coveralls