Does cell.Bool behave properly? #106
Comments
ShawnMilo
added a commit
that referenced
this issue
Apr 18, 2015
Change the behavior of Cell.Bool to be technically more correct.
|
Note: Branch with update and tests pushed. No existing tests were harmed. However, there weren't yet any tests for the boolean cell type. This could affect users in a backwards-incompatible way, but I believe it would only bring unexpected data to their attention, preventing the silent consumption of bad data. |
ShawnMilo
added a commit
that referenced
this issue
May 13, 2015
Change the behavior of Cell.Bool to be technically more correct.
|
Closed by PR #112. |
tealeg
pushed a commit
that referenced
this issue
Apr 1, 2016
Change the behavior of Cell.Bool to be technically more correct.
tealeg
pushed a commit
that referenced
this issue
Jan 14, 2020
Change the behavior of Cell.Bool to be technically more correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
func (c *Cell) Bool() bool {just returnsc.Value == "1".Given that there is a CellType
CellTypeBool, should it check that and usec.Value == "1"if so, and otherwise returnfalsefor""(empty string) andtruefor anything else?The text was updated successfully, but these errors were encountered: