Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve boolean check. #112

Merged
merged 1 commit into from
May 13, 2015
Merged

Improve boolean check. #112

merged 1 commit into from
May 13, 2015

Conversation

ShawnMilo
Copy link
Collaborator

Updates Cell.Bool() to more accurately return a boolean value based on the cell's type.

If it's a boolean cell type, return the boolean value.

If it's a numeric type, False for zero and True for anything else.

Otherwise, return False for "" or True for anything else.

Change the behavior of Cell.Bool to be technically more correct.
@ShawnMilo
Copy link
Collaborator Author

@tealeg: Please review.

tealeg added a commit that referenced this pull request May 13, 2015
@tealeg tealeg merged commit b2cc0d1 into master May 13, 2015
@tealeg
Copy link
Owner

tealeg commented May 13, 2015

Good stuff.

@ShawnMilo ShawnMilo deleted the skm_update_bool branch May 13, 2015 13:49
tealeg pushed a commit that referenced this pull request Apr 1, 2016
tealeg added a commit that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants