Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GirdComp #79 Implement resourse lazy load #75 #91

Merged
merged 10 commits into from
Jan 22, 2022

Conversation

jkpark104
Copy link
Contributor

@jkpark104 jkpark104 commented Jan 21, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • Documentation content changes
  • Other... Please describe:

Related Issue Number

What does this PR do?

feat: Add getRandomCount util func

fix: Modify VideoComp to be applied to grid GridComp

  1. implement responsive css code to video
  2. implement useLayoutEffect hook

fix: Modify Card.styled.tsx

  1. add 'height: 100%' line 10

faet: Create GirdComp #79

  1. todo: redux global state
  2. todo: implement customHook

fix: Off LazyLoading option in CarouselComp

  1. Off the lazy option in CarouselComp due to implementing lazy loading
    through intersection-observer

feat: Implement resourse lazy load #75

  1. implement useVideo hook
  2. implement VideoComp that is loaded la

Other information

1. implement responsive css code to video
2. implement useLayoutEffect hook
1. add 'height: 100%' line 10
1. todo: redux global state
2. todo: implement customHook
@jkpark104 jkpark104 added this to the Sprint3 milestone Jan 21, 2022
@jkpark104 jkpark104 self-assigned this Jan 21, 2022
This was linked to issues Jan 21, 2022
@jkpark104 jkpark104 changed the title Create GirdComp #79 Create GirdComp #79 Jan 21, 2022
1. Off the lazy option in CarouselComp due to implementing lazy loading
   through intersection-observer
1. delete unnecessary codes
1. implement useVideo hook
2. implement VideoComp that is loaded lazy
@jkpark104 jkpark104 changed the title Create GirdComp #79 Create GirdComp #79 Implement resourse lazy load #75 Jan 21, 2022
Copy link
Contributor

@sosoYim sosoYim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

@sosoYim sosoYim merged commit 55fabe6 into team-GIFT:develop Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants