-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GirdComp #79 Implement resourse lazy load #75 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. implement responsive css code to video 2. implement useLayoutEffect hook
1. add 'height: 100%' line 10
1. todo: redux global state 2. todo: implement customHook
This was
linked to
issues
Jan 21, 2022
Closed
1. Off the lazy option in CarouselComp due to implementing lazy loading through intersection-observer
1. delete unnecessary codes
1. implement useVideo hook 2. implement VideoComp that is loaded lazy
This was
linked to
issues
Jan 21, 2022
Closed
Closed
jkpark104
changed the title
Create GirdComp #79
Create GirdComp #79 Implement resourse lazy load #75
Jan 21, 2022
sosoYim
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Related Issue Number
What does this PR do?
feat: Add getRandomCount util func
fix: Modify VideoComp to be applied to grid GridComp
fix: Modify Card.styled.tsx
faet: Create GirdComp #79
fix: Off LazyLoading option in CarouselComp
through intersection-observer
feat: Implement resourse lazy load #75
Other information