Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#671) 엑셀 API 메서드 분리 #696

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Jul 29, 2024

작업 내용 설명

  • ExcelAdapter의 메서드들을 의존도 별 분리

주요 변경 사항

  • ExcelAdapter에서 분리할 메서드를 ExcelPort 로 분리
  • ExcelPort를 ExcelAdapter에 상속하도록 변경

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 added the refactor 코드 리팩토링 할 경우 label Jul 29, 2024
@zios0707 zios0707 self-assigned this Jul 29, 2024
@zios0707 zios0707 linked an issue Jul 29, 2024 that may be closed by this pull request
1 task
@ilyoil2
Copy link
Member

ilyoil2 commented Jul 29, 2024

빌드 깨지는거 확인해주세요

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 3.26797% with 148 lines in your changes missing coverage. Please review.

Project coverage is 3.38%. Comparing base (6210962) to head (2c32dc4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #696      +/-   ##
============================================
- Coverage       3.39%   3.38%   -0.01%     
- Complexity        83      84       +1     
============================================
  Files            610     611       +1     
  Lines           8466    8474       +8     
  Branches         205     205              
============================================
  Hits             287     287              
- Misses          8168    8176       +8     
  Partials          11      11              
Files Coverage Δ
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 15.82% <21.05%> (+6.66%) ⬆️
...eam/aliens/dms/thirdparty/parser/port/ExcelPort.kt 0.74% <0.74%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6210962...2c32dc4. Read the comment docs.

@zios0707 zios0707 requested a review from ilyoil2 July 30, 2024 05:20
@zios0707 zios0707 changed the title megee: (#671) 엑셀 API 메서드 분리 merge: (#671) 엑셀 API 메서드 분리 Jul 30, 2024
Copy link

sonarcloud bot commented Jul 30, 2024

@zios0707 zios0707 merged commit e19dc35 into develop Jul 30, 2024
3 of 4 checks passed
@zios0707 zios0707 deleted the ref/671-excel-api branch July 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

엑셀 API 책임 분리
2 participants