Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandboxing the renderer process #969

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Sandboxing the renderer process #969

wants to merge 5 commits into from
+514 −467

Conversation

hal-shu-sato
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Refer to #837.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hal-shu-sato hal-shu-sato added Feedback: enhancement New feature or request Type: refactoring Refactoring codes labels Nov 16, 2022
@hal-shu-sato hal-shu-sato self-assigned this Nov 16, 2022
@hal-shu-sato hal-shu-sato changed the title Hal shu sato/issue837 Sandboxing the renderer process Nov 16, 2022
@hal-shu-sato hal-shu-sato force-pushed the hal-shu-sato/issue837 branch 2 times, most recently from d0be773 to a846c44 Compare December 10, 2022 05:46
@hal-shu-sato
Copy link
Collaborator Author

I will continue this PR after electron-log v5 is released, for it is hard to debug while developing.

@hal-shu-sato hal-shu-sato force-pushed the hal-shu-sato/issue837 branch 6 times, most recently from 0b80c75 to 453e995 Compare October 7, 2023 19:21
@hal-shu-sato hal-shu-sato force-pushed the hal-shu-sato/issue837 branch 2 times, most recently from 73d78ac to bf2c38b Compare October 22, 2023 10:17
@mitosagi
Copy link
Collaborator

mitosagi commented Nov 1, 2023

Electron log v5 finally released!

@hal-shu-sato
Copy link
Collaborator Author

Thank you for letting me know!!
I am sandboxing apm now so that we can use many features like using an API.
It is a correct separation of process on Electron, I think.

@hal-shu-sato hal-shu-sato force-pushed the hal-shu-sato/issue837 branch 4 times, most recently from f39f6f9 to 09b407a Compare December 31, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hal-shu-sato hal-shu-sato

Labels
Feedback: enhancement New feature or request Type: refactoring Refactoring codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hal-shu-sato @mitosagi