Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(@comma/ds): @comma/ds dependency -> peerDependency로 변경 #24

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

hanseo0507
Copy link
Member

@hanseo0507 hanseo0507 commented Jan 27, 2023

🔍 What is this PR?

Fix #22

🙇 Changes

  • @comma/ds의 모든 dependency를 peerDependency로 변경했어요

    next@13은 optional peerDependency로 설정했어요

📸 스크린 샷

어떤 점이 달라졌는지 알 수 있게끔 스크린 샷을 첨부해주세요.

✅ 체크 리스트

  • @comma/web framer-motion 적용 여부 확인
  • @comma/admin vite 명령어 성공적 실행 확인

@hanseo0507 hanseo0507 added 🐛 버그 버그를 제보하고 싶어요 💻 frontend 해당 이슈는 프론트엔드와 관련 되어있어요 labels Jan 27, 2023
@hanseo0507 hanseo0507 self-assigned this Jan 27, 2023
@vercel
Copy link

vercel bot commented Jan 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hmm-frontend-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 1:32PM (UTC)

Copy link
Member

@cmg8431 cmg8431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanseo0507 hanseo0507 merged commit 6b0bb76 into develop Jan 27, 2023
hanseo0507 added a commit that referenced this pull request Jan 29, 2023
commit 9f41cb2
Author: 최민기 <cmg8431@gmail.com>
Date:   Mon Jan 30 01:11:25 2023 +0900

    feat(@comma/web): 서비스 방향이 변경으로 onBoarding 디자인 변경 #2 (#26)

    * feat(@comma/ds): global 컬러 및 레이아웃 여백 변경

    * feat(@comma/web): 변경된 온보딩 페이지 디자인 반영

    * refactor(@comma/web): 주석 제거 및, import 순서 정렬

    * chore(deps): eslint plugin storybook 업데이트 및 extends 이슈 해결

    * chore: assets svg 폴더 구조 변경

commit 6b0bb76
Author: HanSu Lee <i.hansu.lee@gmail.com>
Date:   Fri Jan 27 22:33:50 2023 +0900

    hotfix(@comma/ds): `@comma/ds` dependency -> peerDependency로 변경 (#24)

    * hotfix(@comma/ds): `@comma/ds` dependency -> peerDependency로 변경

    * fix(deps): yarn post-resolution validation 이슈 해결

commit cbf540c
Author: HanSu Lee <i.hansu.lee@gmail.com>
Date:   Tue Jan 10 17:43:49 2023 +0900

    chore(@comma/ds): `Storybook` 세팅 및 문서화 진행 (#20)

    * chore(@comma/ds): React + Vite 프로젝트 세팅

    * chore(@comma/ds): `Storybook` 프로젝트 셋업

    * docs(@comma/ds): `Storybook` 문서 추가
@hanseo0507 hanseo0507 deleted the hotfix/22-comma-ds-dependency-crash branch January 29, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 버그 버그를 제보하고 싶어요 💻 frontend 해당 이슈는 프론트엔드와 관련 되어있어요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants