-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@comma/web): 서비스 방향이 변경으로 onBoarding 디자인 변경 #2 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cmg8431
changed the title
feat(@comma/web): 서비스의 전체적인 방향이 변경에 따라 onBoarding 디자인 변경 #2
feat(@comma/web): 서비스 방향이 변경으로 onBoarding 디자인 변경 #2
Jan 29, 2023
hanseo0507
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hanseo0507
added a commit
that referenced
this pull request
Jan 29, 2023
commit 9f41cb2 Author: 최민기 <cmg8431@gmail.com> Date: Mon Jan 30 01:11:25 2023 +0900 feat(@comma/web): 서비스 방향이 변경으로 onBoarding 디자인 변경 #2 (#26) * feat(@comma/ds): global 컬러 및 레이아웃 여백 변경 * feat(@comma/web): 변경된 온보딩 페이지 디자인 반영 * refactor(@comma/web): 주석 제거 및, import 순서 정렬 * chore(deps): eslint plugin storybook 업데이트 및 extends 이슈 해결 * chore: assets svg 폴더 구조 변경 commit 6b0bb76 Author: HanSu Lee <i.hansu.lee@gmail.com> Date: Fri Jan 27 22:33:50 2023 +0900 hotfix(@comma/ds): `@comma/ds` dependency -> peerDependency로 변경 (#24) * hotfix(@comma/ds): `@comma/ds` dependency -> peerDependency로 변경 * fix(deps): yarn post-resolution validation 이슈 해결 commit cbf540c Author: HanSu Lee <i.hansu.lee@gmail.com> Date: Tue Jan 10 17:43:49 2023 +0900 chore(@comma/ds): `Storybook` 세팅 및 문서화 진행 (#20) * chore(@comma/ds): React + Vite 프로젝트 세팅 * chore(@comma/ds): `Storybook` 프로젝트 셋업 * docs(@comma/ds): `Storybook` 문서 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What is this PR?
서비스의 전체적인 방향이 변경되며 온보딩 또한, 새로운 디자인으로 반영합니다.
🙇 Changes
어떤 부분이 변경되었는지 설명해주세요.