Expose time-limit parameter from rostest #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschillinger
approved these changes
Feb 9, 2020
|
Looks good to me, thanks for adding! What documentation do you refer to in your TODO? |
|
The state testing one on wiki.ros.org and that also needs an update since #97 |
|
Agree, I plan to update this soon. However, this does not block the PR, so I will merge already. In general, I prefer to rather have functions already available in the installed packages and not yet being covered in the tutorial than describing something in the tutorial that is not yet available in the installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default
rostestmaximum allotted time to each test is 60 seconds. For many behaviors, this isn't enough. Currently the user has to directly specify the test node inflexbe_rostest.testas opposed to using the wrapper. This PR passes through thetime-limitargument so it can be specified from within the user's rostest file.TODO