Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inaccurate /flexbe/behavior_update message #123

Closed
zengxiaolei opened this issue Apr 15, 2020 · 7 comments
Closed

inaccurate /flexbe/behavior_update message #123

zengxiaolei opened this issue Apr 15, 2020 · 7 comments
Assignees
Labels
resolved on develop Resolved on the development branch, no further work expected.

Comments

@zengxiaolei
Copy link

zengxiaolei commented Apr 15, 2020

Hi, I found that the /flexbe/behavior_update can be inaccurate, sometimes state update message can be missing or repeated and sometimes the order of the states update messages can be confusing, especially when behaviors are executed by behavior action without flexbe_app.

Looking forward to a response.

@pschillinger pschillinger self-assigned this Apr 17, 2020
@pschillinger
Copy link
Member

Was able to reproduce the issue when using the action server. I will take a look and let you know.

@pschillinger
Copy link
Member

The issue of not updating the action server should be fixed by the above commit.

Without digging too much into the FlexBE internals, there are two modes for running a behavior: one being controller and one not controlled. So far, only running the user interface was enabling the controlled mode and thus, providing updates to the behavior mirror. Now this is changed so that running the mirror itself is used as an indication whether updates should be sent.

@pxalcantara
Copy link

@pschillinger It's solved in the develop branch. Thanks!! When do you plan to merge it into master?

@pschillinger
Copy link
Member

Thanks for the feedback! I plan the next merge for around end of next week.

@pschillinger pschillinger added the resolved on develop Resolved on the development branch, no further work expected. label Jun 5, 2020
@zengxiaolei
Copy link
Author

Sorry for later feedback, the state update works well now.
Another little suggestion, If /behavior_update message can be latched in default? Then we can always know which state is active now. Now the message is just published on enter of each state, if some state lasts long time, I cannot know the behavior is in which state if I monitor in process. @pschillinger

@tropappar
Copy link

tropappar commented Jan 17, 2022

I need to know which behavior is currently running. I planned to subscribe to the topic in question but it seems only to be available if the GUI is running. But I need to run FlexBE in autonomous mode without operator interaction.
@pschillinger: Is there any way to achieve this?
Also, I agree with @zengxiaolei about latching.

@dcconner
Copy link
Member

Planning to look into latching this at new repo home FlexBE/flexbe_behavior_engine#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved on develop Resolved on the development branch, no further work expected.
Projects
None yet
Development

No branches or pull requests

5 participants