Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Video controls and overall looks #452

Closed
SleepySquash opened this issue Jun 9, 2023 · 0 comments · Fixed by #468
Closed

Improve Video controls and overall looks #452

SleepySquash opened this issue Jun 9, 2023 · 0 comments · Fixed by #468
Assignees
@krida2000
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Milestone
0.1.0-alpha.9

Comments

@SleepySquash
Copy link
Contributor

Background

Видеоплееры переехали на meedu плееры, некоторые UI/UX моменты хочется улучшить.

Problem to solve

Хочется улучшить некоторые UI/UX моменты видео плеера:

  1. Перемотка должна осуществляться моментально, а не при отпускании мыши на кружочке progress bar'а.
  2. На мобилке двойной клик влево/вправо должен визуально как-нибудь отображать тот факт, что произошла перемотка.

Дополнительно хочется исследовать несколько проблем, связанных с видеоплеером:

  1. На всех платформах видео в окно сообщения не BoxFit.cover:
Снимок экрана 2023-06-08 в 12 39 03

  1. При открытии видео присутствует какое-то затемнение, которое через 2-3 секунды плавно пропадает:
    https://github.com/team113/messenger/assets/21217248/a7f6a07e-b487-4d9c-b2f2-6f857359e377

  2. И вижу contain фит в сообщении:

Снимок экрана 2023-06-08 в 13 56 11

Originally posted by @SleepySquash in #445 (comment)
@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Jun 9, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.9 milestone Jun 9, 2023
@SleepySquash SleepySquash self-assigned this Jun 9, 2023
@SleepySquash SleepySquash mentioned this issue Jun 9, 2023
Merged
14 tasks
@krida2000 krida2000 mentioned this issue Jun 29, 2023
Merged
14 tasks
@krida2000 krida2000 assigned krida2000 and unassigned SleepySquash Jul 3, 2023
SleepySquash pushed a commit that referenced this issue Jul 7, 2023
@krida2000
Add RewindIndicators to MobileControls (#468, #452)
7386edf 
Additionally:
- add transparent `Container` to `RoundFloatingButton`
- add `DesktopControls.size` limiting tappable area
- allow `ProgressBar` dragging to seek video immediately
- fix incorrect `Video` fitting mode
github-actions bot added a commit that referenced this issue Jul 7, 2023
@github-actions
Add RewindIndicators to MobileControls (#468, #452)
f50e78d 
Additionally:
- add transparent `Container` to `RoundFloatingButton`
- add `DesktopControls.size` limiting tappable area
- allow `ProgressBar` dragging to seek video immediately
- fix incorrect `Video` fitting mode 7386edf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.9
Development

Successfully merging a pull request may close this issue.

Video improvements (#452) team113/messenger
2 participants
@SleepySquash @krida2000