Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video improvements (#452) #468

Merged
merged 15 commits into from
Jul 7, 2023
Merged

Video improvements (#452) #468

merged 15 commits into from
Jul 7, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jun 29, 2023 •
edited by SleepySquash
Loading

Resolves #452

Synopsis

Некоторые UI/UX моменты звязанные с видео хочется улучшить.

Solution

Необходимые улучшения будут внесены.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jun 29, 2023
@krida2000 krida2000 self-assigned this Jun 29, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Jun 30, 2023 •
edited by SleepySquash
Loading

FCM

Add `RewindIndicator`s to `MobileControls` (#468, #452)

Additionally:
- add transparent `Container` to `RoundFloatingButton`
- add `DesktopControls.size` limiting tappable area
- allow `ProgressBar` dragging to seek video immediately
- fix incorrect `Video` fitting mode

@krida2000 krida2000 marked this pull request as ready for review June 30, 2023 13:57
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Jul 7, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.9 milestone Jul 7, 2023
@SleepySquash SleepySquash merged commit 7386edf into main Jul 7, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 452-improve-video-controls branch July 7, 2023 11:56
github-actions bot added a commit that referenced this pull request Jul 7, 2023
@github-actions
Add RewindIndicators to MobileControls (#468, #452)
f50e78d 
Additionally:
- add transparent `Container` to `RoundFloatingButton`
- add `DesktopControls.size` limiting tappable area
- allow `ProgressBar` dragging to seek video immediately
- fix incorrect `Video` fitting mode 7386edf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.9
Development

Successfully merging this pull request may close these issues.

Improve Video controls and overall looks
2 participants
@krida2000 @SleepySquash