Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement swipe to reply in Chat (#134) #188

Merged
merged 22 commits into from
Nov 8, 2022
Merged

Implement swipe to reply in Chat (#134) #188

merged 22 commits into from
Nov 8, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Oct 27, 2022 •
edited by SleepySquash
Loading

Resolves #134

Synopsis

Отсутствует удобный жест "свайп для ответа", его нужно реализовать.

Solution

Жест, "свайп для ответа" бует реализован.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Oct 27, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.8 milestone Oct 27, 2022
@krida2000 krida2000 self-assigned this Oct 27, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Oct 31, 2022 •
edited by SleepySquash
Loading

FCM

Implement swipe to reply gesture in `Chat` (#188, #134)

Additionally:
- add haptic feedback when opening/closing timeline
- fix inability to scroll `Attachment`s by dragging
- impl `onPointerPanZoomUpdate` event handling in `Chat`
- make `DateTimeElement` to be sticky header in `Chat`

@krida2000 krida2000 marked this pull request as ready for review October 31, 2022 11:12
@SleepySquash SleepySquash requested review from skazkiful and removed request for SleepySquash October 31, 2022 19:00
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Nov 2, 2022
SleepySquash
SleepySquash requested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, гляньте, пожалуйста, поведение таймлайна и скролла списка сообщений на телефоне - к нему есть вопросы в плане юзабельности. Всё остальное, вроде бы, отлично работает, вопросов нет.

lib/ui/page/home/page/chat/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft November 3, 2022 08:21
@krida2000 krida2000 marked this pull request as ready for review November 3, 2022 14:10
SleepySquash
SleepySquash requested changes Nov 4, 2022
View reviewed changes
lib/ui/page/home/page/chat/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash enabled auto-merge (squash) November 8, 2022 08:59
@SleepySquash SleepySquash merged commit 202a548 into main Nov 8, 2022
@SleepySquash SleepySquash deleted the 134-add-swipe-to-reply branch November 8, 2022 09:00
github-actions bot added a commit that referenced this pull request Nov 8, 2022
@github-actions
Implement swipe to reply gesture in Chat (#188, #134)
e1a4bdd 
Additionally:
- add haptic feedback when opening/closing timeline
- fix inability to scroll `Attachment`s by dragging
- impl `onPointerPanZoomUpdate` event handling in `Chat`
- make `DateTimeElement` to be sticky header in `Chat` 202a548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

@skazkiful skazkiful skazkiful approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Implement swipe to reply in Chat
3 participants
@krida2000 @SleepySquash @skazkiful